services/navigation/view_impl.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/navigation/view_impl.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/navigation/view_impl.cc

diff --git a/services/navigation/view_impl.cc b/services/navigation/view_impl.cc

index a6451d12f77e5c2999bee48fcb55c3a31595fd7e..22999a87e2256c2bdd33aa6a1b6274203b1ea803 100644

--- a/services/navigation/view_impl.cc

+++ b/services/navigation/view_impl.cc

@@ -144,7 +144,8 @@ void ViewImpl::AddNewContents(content::WebContents* source,

mojom::ViewPtr view;

mojom::ViewRequest view_request = GetProxy(&view);

client_->ViewCreated(std::move(view), GetProxy(&client),

- disposition == NEW_POPUP, initial_rect, user_gesture);

+ disposition == WindowOpenDisposition::NEW_POPUP,

+ initial_rect, user_gesture);

const std::string new_user_id =

content::BrowserContext::GetShellUserIdFor(