content/renderer/render_frame_proxy.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_proxy.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_proxy.cc

diff --git a/content/renderer/render_frame_proxy.cc b/content/renderer/render_frame_proxy.cc

index 96316d4cae8ed0142704d559abc7e0395603fac4..4053b914200a1598e5ec712d4771dc28c49dc35f 100644

--- a/content/renderer/render_frame_proxy.cc

+++ b/content/renderer/render_frame_proxy.cc

@@ -449,7 +449,7 @@ void RenderFrameProxy::navigate(const blink::WebURLRequest& request,

blink::WebStringToGURL(

request.httpHeaderField(blink::WebString::fromUTF8("Referer"))),

request.referrerPolicy());

- params.disposition = CURRENT_TAB;

+ params.disposition = WindowOpenDisposition::CURRENT_TAB;

params.should_replace_current_entry = should_replace_current_entry;

params.user_gesture =

blink::WebUserGestureIndicator::isProcessingUserGesture();