content/browser/web_contents/web_contents_impl_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl_browsertest.cc

diff --git a/content/browser/web_contents/web_contents_impl_browsertest.cc b/content/browser/web_contents/web_contents_impl_browsertest.cc

index d1f781f96b3ebaa621da0f5a7bb181137c7524a0..21113083f7e9a29aaf74aa79d0f5135efb96f42c 100644

--- a/content/browser/web_contents/web_contents_impl_browsertest.cc

+++ b/content/browser/web_contents/web_contents_impl_browsertest.cc

@@ -382,7 +382,8 @@ IN_PROC_BROWSER_TEST_F(WebContentsImplBrowserTest, OpenURLSubframe) {

// Navigate with the subframe's FrameTreeNode ID.

const GURL url(embedded_test_server()->GetURL("/title1.html"));

- OpenURLParams params(url, Referrer(), frame_tree_node_id, CURRENT_TAB,

+ OpenURLParams params(url, Referrer(), frame_tree_node_id,

+ WindowOpenDisposition::CURRENT_TAB,

ui::PAGE_TRANSITION_LINK, true);

shell()->web_contents()->OpenURL(params);