content/browser/site_per_process_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/site_per_process_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/site_per_process_browsertest.cc

diff --git a/content/browser/site_per_process_browsertest.cc b/content/browser/site_per_process_browsertest.cc

index 32e9079fd710589f56f2898cd536318dfb8af49e..f97ba9f280b675fbc6c8270154ecce55e8e3e376 100644

--- a/content/browser/site_per_process_browsertest.cc

+++ b/content/browser/site_per_process_browsertest.cc

@@ -7253,9 +7253,11 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,

// Now, simulate that both ShowView messages arrive by showing both of the

// pending WebContents.

web_contents()->ShowCreatedWindow(process1->GetID(), filter1->routing_id(),

- NEW_FOREGROUND_TAB, gfx::Rect(), true);

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ gfx::Rect(), true);

web_contents()->ShowCreatedWindow(process2->GetID(), filter2->routing_id(),

- NEW_FOREGROUND_TAB, gfx::Rect(), true);

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ gfx::Rect(), true);

// Verify that both shells were properly created.

EXPECT_EQ(3u, Shell::windows().size());