content/browser/frame_host/navigator_impl.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index d0c1f85a4f3ba3fad4de173b5cd1f2bf36bf372f..0b015ddb698d4b5505b777ebcb9575094a1d25b8 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -703,7 +703,8 @@ void NavigatorImpl::RequestOpenURL(

// subframe in the current tab. We'll assume it's for the main frame

// (possibly of a new or different WebContents) otherwise.

if (SiteIsolationPolicy::UseSubframeNavigationEntries() &&

- disposition == CURRENT_TAB && render_frame_host->GetParent()) {

+ disposition == WindowOpenDisposition::CURRENT_TAB &&

+ render_frame_host->GetParent()) {

frame_tree_node_id =

render_frame_host->frame_tree_node()->frame_tree_node_id();

}