components/translate/content/browser/content_translate_driver.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/content/browser/content_translate_driver.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/translate/content/browser/content_translate_driver.cc

diff --git a/components/translate/content/browser/content_translate_driver.cc b/components/translate/content/browser/content_translate_driver.cc

index e9a6fe9fe1487de4acd4566b217a1b1a6d7c7dc7..9860c307388dcf0d6b191cccef217af143e12bed 100644

--- a/components/translate/content/browser/content_translate_driver.cc

+++ b/components/translate/content/browser/content_translate_driver.cc

@@ -146,11 +146,9 @@ bool ContentTranslateDriver::HasCurrentPage() {

}

void ContentTranslateDriver::OpenUrlInNewTab(const GURL& url) {

- content::OpenURLParams params(url,

- content::Referrer(),

- NEW_FOREGROUND_TAB,

- ui::PAGE_TRANSITION_LINK,

- false);

+ content::OpenURLParams params(url, content::Referrer(),

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ ui::PAGE_TRANSITION_LINK, false);

navigation_controller_->GetWebContents()->OpenURL(params);

}