components/omnibox/browser/omnibox_edit_controller.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/omnibox_edit_controller.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/omnibox/browser/omnibox_edit_controller.cc

diff --git a/components/omnibox/browser/omnibox_edit_controller.cc b/components/omnibox/browser/omnibox_edit_controller.cc

index 1b653b24b8e63e4ad70d87e34916f8ca1b97d164..6b2980c828942e5e71542fe0842b5d1e012f32f3 100644

--- a/components/omnibox/browser/omnibox_edit_controller.cc

+++ b/components/omnibox/browser/omnibox_edit_controller.cc

@@ -15,7 +15,7 @@ void OmniboxEditController::OnAutocompleteAccept(

}

OmniboxEditController::OmniboxEditController()

- : disposition_(CURRENT_TAB),

+ : disposition_(WindowOpenDisposition::CURRENT_TAB),

transition_(ui::PageTransitionFromInt(

ui::PAGE_TRANSITION_TYPED | ui::PAGE_TRANSITION_FROM_ADDRESS_BAR)) {}