chrome/test/remoting/it2me_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/remoting/it2me_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/remoting/it2me_browsertest.cc

diff --git a/chrome/test/remoting/it2me_browsertest.cc b/chrome/test/remoting/it2me_browsertest.cc

index 0c35eae0cb674063df043d14657018e8c4fde9da..6a9123a4a074cff4676fafc89cc9877d01eefdfc 100644

--- a/chrome/test/remoting/it2me_browsertest.cc

+++ b/chrome/test/remoting/it2me_browsertest.cc

@@ -26,7 +26,7 @@ std::string It2MeBrowserTest::GetAccessCode(content::WebContents* contents) {

content::WebContents* It2MeBrowserTest::SetUpHelperInstance() {

content::WebContents* helper_content =

- LaunchChromotingApp(false, NEW_FOREGROUND_TAB);

+ LaunchChromotingApp(false, WindowOpenDisposition::NEW_FOREGROUND_TAB);

LoadBrowserTestJavaScript(helper_content);

LoadScript(helper_content, FILE_PATH_LITERAL("it2me_browser_test.js"));

return helper_content;