chrome/browser/ui/zoom/zoom_controller_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/zoom/zoom_controller_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/zoom/zoom_controller_browsertest.cc

diff --git a/chrome/browser/ui/zoom/zoom_controller_browsertest.cc b/chrome/browser/ui/zoom/zoom_controller_browsertest.cc

index 6d5f993895cb8b97b89c02ea0e292177fadd6abe..d0d8ea33a8c492f3e1605ef478a76dedcdfd71b9 100644

--- a/chrome/browser/ui/zoom/zoom_controller_browsertest.cc

+++ b/chrome/browser/ui/zoom/zoom_controller_browsertest.cc

@@ -180,7 +180,7 @@ IN_PROC_BROWSER_TEST_F(ZoomControllerBrowserTest,

ASSERT_TRUE(tab_strip);

ui_test_utils::NavigateToURLWithDisposition(

- browser(), url, NEW_FOREGROUND_TAB,

+ browser(), url, WindowOpenDisposition::NEW_FOREGROUND_TAB,

ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

{

content::WebContents* web_contents = tab_strip->GetActiveWebContents();

@@ -286,7 +286,7 @@ IN_PROC_BROWSER_TEST_F(ZoomControllerBrowserTest,

// signin page, the HostZoomMap changes, and we need to test that the

// ZoomController correctly detects this.

ui_test_utils::NavigateToURLWithDisposition(

- browser(), signin_url, NEW_FOREGROUND_TAB,

+ browser(), signin_url, WindowOpenDisposition::NEW_FOREGROUND_TAB,

ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

login_ui_test_utils::WaitUntilUIReady(browser());

content::WebContents* web_contents =