chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/signin/login_ui_test_utils.cc ('k') | chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc » ('j') | ui/base/window_open_disposition.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc

diff --git a/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc b/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc

index 9f1497ec02ead466588e482e0de4791ea4132b3d..df3a14b498f6323cdab49b68b50c7960a1fca9f0 100644

--- a/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc

+++ b/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc

@@ -103,11 +103,9 @@ void SigninSupervisedUserImportHandler::OpenUrlInLastActiveProfileBrowser(

std::string url;

bool success = args->GetString(0, &url);

DCHECK(success);

- content::OpenURLParams params(GURL(url),

- content::Referrer(),

- NEW_FOREGROUND_TAB,

- ui::PAGE_TRANSITION_LINK,

- false);

+ content::OpenURLParams params(GURL(url), content::Referrer(),

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ ui::PAGE_TRANSITION_LINK, false);

// ProfileManager::GetLastUsedProfile() will attempt to load the default

// profile if there is no last used profile. If the default profile is not

// fully loaded and initialized, it will attempt to do so synchronously.