Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc
diff --git a/chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc b/chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc
index 8ffe5a7498ecadb9be46dd12587910f683638c3f..0e019c935b099b00359b0daccabdb2f02aa572db 100644
--- a/chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc
@@ -78,18 +78,20 @@ IN_PROC_BROWSER_TEST_F(NewTabUIProcessPerTabTest, NavBeforeNTPCommits) {
// Navigate to chrome://hang/ to stall the process.
ui_test_utils::NavigateToURLWithDisposition(
- browser(), GURL(content::kChromeUIHangURL), CURRENT_TAB, 0);
+ browser(), GURL(content::kChromeUIHangURL),
+ WindowOpenDisposition::CURRENT_TAB, 0);
// Visit a normal URL in another NTP that hasn't committed.
ui_test_utils::NavigateToURLWithDisposition(
- browser(), GURL(chrome::kChromeUINewTabURL), NEW_FOREGROUND_TAB, 0);
+ browser(), GURL(chrome::kChromeUINewTabURL),
+ WindowOpenDisposition::NEW_FOREGROUND_TAB, 0);
// We don't use ui_test_utils::NavigateToURLWithDisposition because that waits
// for current loading to stop.
content::TestNavigationObserver observer(
browser()->tab_strip_model()->GetActiveWebContents());
browser()->OpenURL(OpenURLParams(
- GURL("data:text/html,hello world"), Referrer(), CURRENT_TAB,
- ui::PAGE_TRANSITION_TYPED, false));
+ GURL("data:text/html,hello world"), Referrer(),
+ WindowOpenDisposition::CURRENT_TAB, ui::PAGE_TRANSITION_TYPED, false));
observer.Wait();
}

Powered by Google App Engine
This is Rietveld 408576698