chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/sad_tab_view.cc ('k') | chrome/browser/ui/views/session_crashed_bubble_view.cc » ('j') | ui/base/window_open_disposition.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc

diff --git a/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc b/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc

index 2da83f665ba71aa8c98b18fd3e3ccb3aa897d007..d8a543259832683fe3b4e499121c0b549f7c8440 100644

--- a/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc

+++ b/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc

@@ -366,7 +366,7 @@ IN_PROC_BROWSER_TEST_F(SelectFileDialogExtensionBrowserTest,

chrome::NavigateParams p(browser(), GURL("http://www.google.com"),

ui::PAGE_TRANSITION_LINK);

p.window_action = chrome::NavigateParams::SHOW_WINDOW;

- p.disposition = SINGLETON_TAB;

+ p.disposition = WindowOpenDisposition::SINGLETON_TAB;

chrome::Navigate(&p);

// Press cancel button.

« no previous file with comments | « chrome/browser/ui/views/sad_tab_view.cc ('k') | chrome/browser/ui/views/session_crashed_bubble_view.cc » ('j') | ui/base/window_open_disposition.h » ('J')