chrome/browser/ui/omnibox/omnibox_view_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

diff --git a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

index 9fea9c01e11f66a79c67f239a1befb7f7444a6c9..35b02b472a03a30e5663121e1612a8c19225c164 100644

--- a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

+++ b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

@@ -692,7 +692,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, ClearUserTextAfterBackgroundCommit) {

GURL url2("data:text/html,page2");

chrome::NavigateParams params(browser(), url2, ui::PAGE_TRANSITION_LINK);

params.source_contents = contents;

- params.disposition = CURRENT_TAB;

+ params.disposition = WindowOpenDisposition::CURRENT_TAB;

ui_test_utils::NavigateToURL(&params);

// Switch back to the first tab. The user text should be cleared, and the