Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: chrome/browser/ui/extensions/application_launch.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/application_launch.cc
diff --git a/chrome/browser/ui/extensions/application_launch.cc b/chrome/browser/ui/extensions/application_launch.cc
index 9a98e55f8c0951988246cbb865beff34e25a78a5..73738674e95b2ec38ebca764077a9bb038ab4099 100644
--- a/chrome/browser/ui/extensions/application_launch.cc
+++ b/chrome/browser/ui/extensions/application_launch.cc
@@ -231,7 +231,7 @@ WebContents* OpenApplicationTab(const AppLaunchParams& launch_params,
browser = new Browser(Browser::CreateParams(Browser::TYPE_TABBED, profile));
browser->window()->Show();
// There's no current tab in this browser window, so add a new one.
- disposition = NEW_FOREGROUND_TAB;
+ disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
} else {
// For existing browser, ensure its window is shown and activated.
browser->window()->Show();
@@ -251,7 +251,7 @@ WebContents* OpenApplicationTab(const AppLaunchParams& launch_params,
params.tabstrip_add_types = add_type;
params.disposition = disposition;
- if (disposition == CURRENT_TAB) {
+ if (disposition == WindowOpenDisposition::CURRENT_TAB) {
WebContents* existing_tab =
browser->tab_strip_model()->GetActiveWebContents();
TabStripModel* model = browser->tab_strip_model();
@@ -386,7 +386,8 @@ WebContents* OpenAppShortcutWindow(Profile* profile,
const GURL& url) {
AppLaunchParams launch_params(profile,
NULL, // this is a URL app. No extension.
- extensions::LAUNCH_CONTAINER_WINDOW, NEW_WINDOW,
+ extensions::LAUNCH_CONTAINER_WINDOW,
+ WindowOpenDisposition::NEW_WINDOW,
extensions::SOURCE_COMMAND_LINE);
launch_params.override_url = url;

Powered by Google App Engine
This is Rietveld 408576698