chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm b/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm

index 6ffe997dd96da57e7dd9b54b5728dee52c7ef281..8425d1d16a8c14b66ee974a7b6c8e9ce04b8d64d 100644

--- a/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm

@@ -840,9 +840,9 @@ const CGFloat kContentWidth = kWindowWidth - 2 * kFramePadding;

- (IBAction)handleLanguageSettingsLinkButtonPressed:(id)sender {

GURL url = chrome::GetSettingsUrl(chrome::kLanguageOptionsSubPage);

- webContents_->OpenURL(

- content::OpenURLParams(url, content::Referrer(), NEW_FOREGROUND_TAB,

- ui::PAGE_TRANSITION_LINK, false));

+ webContents_->OpenURL(content::OpenURLParams(

+ url, content::Referrer(), WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ ui::PAGE_TRANSITION_LINK, false));

translate::ReportUiAction(translate::SETTINGS_LINK_CLICKED);

[self close];

}