chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.mm » ('j') | ui/base/window_open_disposition.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm

index 9ba3378bc83cb2760e15a7bb1722fc311d3f6d64..68ea53244f0944b643936b267bf9827321cab743 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm

@@ -747,7 +747,7 @@ TEST_F(BookmarkBarControllerTest, OpenBookmark) {

[bar_ openBookmark:button];

EXPECT_EQ(noOpenBar()->urls_[0], node->url());

- EXPECT_EQ(noOpenBar()->dispositions_[0], CURRENT_TAB);

+ EXPECT_EQ(noOpenBar()->dispositions_[0], WindowOpenDisposition::CURRENT_TAB);

}

TEST_F(BookmarkBarControllerTest, TestAddRemoveAndClear) {

@@ -1793,8 +1793,9 @@ TEST_F(BookmarkBarControllerOpenAllTest, CommandClickOnFolder) {

[first performClick:first];

size_t dispositionCount = noOpenBar()->dispositions_.size();

- EXPECT_EQ(originalDispositionCount+1, dispositionCount);

- EXPECT_EQ(noOpenBar()->dispositions_[dispositionCount-1], NEW_BACKGROUND_TAB);

+ EXPECT_EQ(originalDispositionCount + 1, dispositionCount);

+ EXPECT_EQ(noOpenBar()->dispositions_[dispositionCount - 1],

+ WindowOpenDisposition::NEW_BACKGROUND_TAB);

// Replace NSApp

NSApp = oldApp;