Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3485)

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_command_controller.cc
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index 1b2d8fa683233407acaf05fde2a0fe44d2f51243..3e03a1b24e36281f7108586d63506ee8eb9d7b92 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -124,7 +124,7 @@ BrowserCommandController::BrowserCommandController(Browser* browser)
command_updater_(this),
block_command_execution_(false),
last_blocked_command_id_(-1),
- last_blocked_command_disposition_(CURRENT_TAB) {
+ last_blocked_command_disposition_(WindowOpenDisposition::CURRENT_TAB) {
browser_->tab_strip_model()->AddObserver(this);
PrefService* local_state = g_browser_process->local_state();
if (local_state) {
@@ -240,7 +240,7 @@ void BrowserCommandController::SetBlockCommandExecution(bool block) {
block_command_execution_ = block;
if (block) {
last_blocked_command_id_ = -1;
- last_blocked_command_disposition_ = CURRENT_TAB;
+ last_blocked_command_disposition_ = WindowOpenDisposition::CURRENT_TAB;
}
}

Powered by Google App Engine
This is Rietveld 408576698