chrome/browser/safe_browsing/safe_browsing_blocking_page.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service.cc ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc » ('j') | ui/base/window_open_disposition.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

index 60517c2f66a9fbea98c9671d5f61028d9367db7f..4fbdcf099ee864287b0c000e3bde625879faba90 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

@@ -253,11 +253,9 @@ void SafeBrowsingBlockingPage::CommandReceived(const std::string& page_cmd) {

GURL learn_more_url(kLearnMore);

learn_more_url = google_util::AppendGoogleLocaleParam(

learn_more_url, g_browser_process->GetApplicationLocale());

- OpenURLParams params(learn_more_url,

- Referrer(),

- CURRENT_TAB,

- ui::PAGE_TRANSITION_LINK,

- false);

+ OpenURLParams params(learn_more_url, Referrer(),

+ WindowOpenDisposition::CURRENT_TAB,

+ ui::PAGE_TRANSITION_LINK, false);

web_contents()->OpenURL(params);

break;

}

@@ -318,9 +316,9 @@ void SafeBrowsingBlockingPage::CommandReceived(const std::string& page_cmd) {

unsafe_resource.threat_type ==

SB_THREAT_TYPE_CLIENT_SIDE_MALWARE_URL ||

unsafe_resource.threat_type == SB_THREAT_TYPE_URL_UNWANTED);

- OpenURLParams params(

- diagnostic_url, Referrer(), CURRENT_TAB, ui::PAGE_TRANSITION_LINK,

- false);

+ OpenURLParams params(diagnostic_url, Referrer(),

+ WindowOpenDisposition::CURRENT_TAB,

+ ui::PAGE_TRANSITION_LINK, false);

web_contents()->OpenURL(params);

break;

}

@@ -337,7 +335,8 @@ void SafeBrowsingBlockingPage::CommandReceived(const std::string& page_cmd) {

GURL phishing_error_url(kReportPhishingErrorUrl);

phishing_error_url = google_util::AppendGoogleLocaleParam(

phishing_error_url, g_browser_process->GetApplicationLocale());

- OpenURLParams params(phishing_error_url, Referrer(), CURRENT_TAB,

+ OpenURLParams params(phishing_error_url, Referrer(),

+ WindowOpenDisposition::CURRENT_TAB,

ui::PAGE_TRANSITION_LINK, false);

web_contents()->OpenURL(params);

break;