Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1836)

Unified Diff: chrome/browser/password_manager/password_manager_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_browsertest.cc
diff --git a/chrome/browser/password_manager/password_manager_browsertest.cc b/chrome/browser/password_manager/password_manager_browsertest.cc
index 6a383b67368fd96ea0a735490518d1f7812af13f..a8a471fb60ff2d5f3d32cf72fcfe1e77cbaeb141 100644
--- a/chrome/browser/password_manager/password_manager_browsertest.cc
+++ b/chrome/browser/password_manager/password_manager_browsertest.cc
@@ -1290,9 +1290,8 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, NoLastLoadGoodLastLoad) {
// WebContents, but don't wait for navigation, which only finishes after
// authentication.
ui_test_utils::NavigateToURLWithDisposition(
- browser(),
- embedded_test_server()->GetURL("/basic_auth"),
- NEW_FOREGROUND_TAB,
+ browser(), embedded_test_server()->GetURL("/basic_auth"),
+ WindowOpenDisposition::NEW_FOREGROUND_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB);
content::NavigationController* nav_controller =
@@ -2586,8 +2585,8 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
&WebContents()->GetController();
WindowedAuthNeededObserver auth_needed_observer(nav_controller);
ui_test_utils::NavigateToURLWithDisposition(
- browser(), embedded_test_server()->GetURL("/basic_auth"), CURRENT_TAB,
- ui_test_utils::BROWSER_TEST_NONE);
+ browser(), embedded_test_server()->GetURL("/basic_auth"),
+ WindowOpenDisposition::CURRENT_TAB, ui_test_utils::BROWSER_TEST_NONE);
auth_needed_observer.Wait();
// The auth dialog caused a query to PasswordStore, make sure it was
@@ -2752,13 +2751,15 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
#endif
IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, MAYBE_InternalsPage) {
ui_test_utils::NavigateToURLWithDisposition(
- browser(), GURL("chrome://password-manager-internals"), CURRENT_TAB,
+ browser(), GURL("chrome://password-manager-internals"),
+ WindowOpenDisposition::CURRENT_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
content::WebContents* internals_web_contents = WebContents();
ui_test_utils::NavigateToURLWithDisposition(
browser(), embedded_test_server()->GetURL("/password/password_form.html"),
- NEW_FOREGROUND_TAB, ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
+ WindowOpenDisposition::NEW_FOREGROUND_TAB,
+ ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
std::string find_renderer_logs =
"var text = document.getElementById('log-entries').innerText;"

Powered by Google App Engine
This is Rietveld 408576698