Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2051)

Unified Diff: chrome/browser/infobars/infobar_service.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/infobars/infobar_service.cc
diff --git a/chrome/browser/infobars/infobar_service.cc b/chrome/browser/infobars/infobar_service.cc
index 71b925185988c456a7f045fb05039605681a4e39..5d0ef27140d37d4c146bec37b5590e870758ae8b 100644
--- a/chrome/browser/infobars/infobar_service.cc
+++ b/chrome/browser/infobars/infobar_service.cc
@@ -119,8 +119,10 @@ void InfoBarService::OpenURL(const GURL& url,
// A normal user click on an infobar URL will result in a CURRENT_TAB
// disposition; turn that into a NEW_FOREGROUND_TAB so that we don't end up
// smashing the page the user is looking at.
- web_contents()->OpenURL(content::OpenURLParams(
- url, content::Referrer(),
- (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
- ui::PAGE_TRANSITION_LINK, false));
+ web_contents()->OpenURL(
+ content::OpenURLParams(url, content::Referrer(),
+ (disposition == WindowOpenDisposition::CURRENT_TAB)
+ ? WindowOpenDisposition::NEW_FOREGROUND_TAB
+ : disposition,
+ ui::PAGE_TRANSITION_LINK, false));
}

Powered by Google App Engine
This is Rietveld 408576698