chrome/browser/extensions/crx_installer_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/crx_installer_browsertest.cc

diff --git a/chrome/browser/extensions/crx_installer_browsertest.cc b/chrome/browser/extensions/crx_installer_browsertest.cc

index 1b39305986f9b0e9bca084ef9caf43b410751e32..a063bc6025efda3e537d51a666540599e300fb2e 100644

--- a/chrome/browser/extensions/crx_installer_browsertest.cc

+++ b/chrome/browser/extensions/crx_installer_browsertest.cc

@@ -373,7 +373,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, PackAndInstallExtension) {

download_manager, kNumDownloadsExpected,

content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_ACCEPT));

LOG(ERROR) << "PackAndInstallExtension: Navigating to URL";

- ui_test_utils::NavigateToURLWithDisposition(browser(), url, CURRENT_TAB,

+ ui_test_utils::NavigateToURLWithDisposition(

+ browser(), url, WindowOpenDisposition::CURRENT_TAB,

ui_test_utils::BROWSER_TEST_NONE);

EXPECT_TRUE(WaitForCrxInstallerDone());