chrome/browser/extensions/api/omnibox/omnibox_api.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_api.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/omnibox/omnibox_api.cc

diff --git a/chrome/browser/extensions/api/omnibox/omnibox_api.cc b/chrome/browser/extensions/api/omnibox/omnibox_api.cc

index 04ab949662f5d87a105f5f0cbc09c0b1f13eb9e8..74bf54d3f87aa0cb04c834b85943380db405aba7 100644

--- a/chrome/browser/extensions/api/omnibox/omnibox_api.cc

+++ b/chrome/browser/extensions/api/omnibox/omnibox_api.cc

@@ -152,9 +152,9 @@ void ExtensionOmniboxEventRouter::OnInputEntered(

std::unique_ptr<base::ListValue> args(new base::ListValue());

args->Set(0, new base::StringValue(input));

- if (disposition == NEW_FOREGROUND_TAB)

+ if (disposition == WindowOpenDisposition::NEW_FOREGROUND_TAB)

args->Set(1, new base::StringValue(kForegroundTabDisposition));

- else if (disposition == NEW_BACKGROUND_TAB)

+ else if (disposition == WindowOpenDisposition::NEW_BACKGROUND_TAB)

args->Set(1, new base::StringValue(kBackgroundTabDisposition));

else

args->Set(1, new base::StringValue(kCurrentTabDisposition));