chrome/browser/extensions/api/management/chrome_management_api_delegate.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc ('k') | chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc » ('j') | ui/base/window_open_disposition.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

diff --git a/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc b/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

index 85896d4d402df1151d0054e3198d7993178d15e7..2f72ec2eaddaf155b340f8deaf0a8d0cc82a0aed 100644

--- a/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

+++ b/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

@@ -179,9 +179,10 @@ void ChromeManagementAPIDelegate::LaunchAppFunctionDelegate(

// returned.

extensions::LaunchContainer launch_container =

GetLaunchContainer(extensions::ExtensionPrefs::Get(context), extension);

- OpenApplication(AppLaunchParams(

- Profile::FromBrowserContext(context), extension, launch_container,

- NEW_FOREGROUND_TAB, extensions::SOURCE_MANAGEMENT_API));

+ OpenApplication(AppLaunchParams(Profile::FromBrowserContext(context),

+ extension, launch_container,

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ extensions::SOURCE_MANAGEMENT_API));

extensions::RecordAppLaunchType(extension_misc::APP_LAUNCH_EXTENSION_API,

extension->GetType());

}