chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc » ('j') | ui/base/window_open_disposition.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc

diff --git a/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc b/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc

index c4637b846c5a9f651abb50103a0382716d84cc89..f4b3aa3c022d3becf0bbc94c1207be67020f43b2 100644

--- a/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc

+++ b/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc

@@ -185,7 +185,8 @@ IN_PROC_BROWSER_TEST_F(CertificateProviderApiTest, Basic) {

nullptr /* no WebContents */);

navigation_observer.StartWatchingNewWebContents();

ui_test_utils::NavigateToURLWithDisposition(

- browser(), https_server.GetURL("client-cert"), NEW_FOREGROUND_TAB,

+ browser(), https_server.GetURL("client-cert"),

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

ui_test_utils::BROWSER_TEST_NONE);

content::WebContents* const https_contents =