chrome/browser/download/download_commands.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_commands.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_commands.cc

diff --git a/chrome/browser/download/download_commands.cc b/chrome/browser/download/download_commands.cc

index 608ab5fe8e4d3bba70f8d61594148f2b91732252..9997315d5016f16e8bf2a8074e881a9b3b997b80 100644

--- a/chrome/browser/download/download_commands.cc

+++ b/chrome/browser/download/download_commands.cc

@@ -343,7 +343,8 @@ void DownloadCommands::ExecuteCommand(Command command) {

case LEARN_MORE_INTERRUPTED:

GetBrowser()->OpenURL(content::OpenURLParams(

GetLearnMoreURLForInterruptedDownload(), content::Referrer(),

- NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_LINK, false));

+ WindowOpenDisposition::NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_LINK,

+ false));

break;

case PAUSE:

download_item_->Pause();