chrome/browser/devtools/devtools_window.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/devtools_window.cc

diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc

index c35f629827ff94a812edac303cf71396a3c6ff0e..356bd93fc4aa0c31b2e8afc131d35e9a390881e5 100644

--- a/chrome/browser/devtools/devtools_window.cc

+++ b/chrome/browser/devtools/devtools_window.cc

@@ -1132,9 +1132,9 @@ void DevToolsWindow::SetIsDocked(bool dock_requested) {

}

void DevToolsWindow::OpenInNewTab(const std::string& url) {

- content::OpenURLParams params(

- GURL(url), content::Referrer(), NEW_FOREGROUND_TAB,

- ui::PAGE_TRANSITION_LINK, false);

+ content::OpenURLParams params(GURL(url), content::Referrer(),

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ ui::PAGE_TRANSITION_LINK, false);

WebContents* inspected_web_contents = GetInspectedWebContents();

if (!inspected_web_contents || !inspected_web_contents->OpenURL(params)) {

chrome::ScopedTabbedBrowserDisplayer displayer(profile_);