chrome/browser/devtools/chrome_devtools_discovery_provider.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/chrome_devtools_discovery_provider.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/chrome_devtools_discovery_provider.cc

diff --git a/chrome/browser/devtools/chrome_devtools_discovery_provider.cc b/chrome/browser/devtools/chrome_devtools_discovery_provider.cc

index e6717ecb5f2613246b65b27f652c9944d79597b3..5507ec4b5eb72f12ec95e8912948a42bef40c42a 100644

--- a/chrome/browser/devtools/chrome_devtools_discovery_provider.cc

+++ b/chrome/browser/devtools/chrome_devtools_discovery_provider.cc

@@ -16,7 +16,7 @@ scoped_refptr<content::DevToolsAgentHost>

CreateNewChromeTab(const GURL& url) {

chrome::NavigateParams params(ProfileManager::GetLastUsedProfile(),

url, ui::PAGE_TRANSITION_AUTO_TOPLEVEL);

- params.disposition = NEW_FOREGROUND_TAB;

+ params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;

chrome::Navigate(&params);

if (!params.target_contents)

return nullptr;