chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc ('k') | chrome/browser/chromeos/login/screens/error_screen.cc » ('j') | ui/base/window_open_disposition.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.cc

diff --git a/chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.cc b/chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.cc

index 63a08f0279b0318bd18ad5781b0746999119163d..99103682aa6ee9aea6a6ec61dc273b56be53ccd1 100644

--- a/chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.cc

+++ b/chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.cc

@@ -118,7 +118,7 @@ void QuickUnlockNotificationController::Click() {

chrome::NavigateParams params(profile_,

GURL(kChromeAuthenticationSettingsURL),

ui::PAGE_TRANSITION_LINK);

- params.disposition = NEW_FOREGROUND_TAB;

+ params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;

params.window_action = chrome::NavigateParams::SHOW_WINDOW;

chrome::Navigate(&params);