Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2957)

Unified Diff: blimp/engine/app/blimp_metrics_service_client.cc

Issue 2248793002: Remove OnRecordingDisabled() metrics client interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add helper function Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/app/blimp_metrics_service_client.cc
diff --git a/blimp/engine/app/blimp_metrics_service_client.cc b/blimp/engine/app/blimp_metrics_service_client.cc
index 6149b5a333eab772900fc8cf32679a358101c0fe..5b25f9349fbaa2c467c459319865ffb06099c0fb 100644
--- a/blimp/engine/app/blimp_metrics_service_client.cc
+++ b/blimp/engine/app/blimp_metrics_service_client.cc
@@ -90,13 +90,10 @@ metrics::MetricsService* BlimpMetricsServiceClient::GetMetricsService() {
// In Chrome, UMA and Breakpad are enabled/disabled together by the same
// checkbox and they share the same client ID (a.k.a. GUID).
-// This is not required by Blimp, so these are no-ops.
+// This is not required by Blimp, so this is a no-op.
void BlimpMetricsServiceClient::SetMetricsClientId(
const std::string& client_id) {}
-// Recording can not be disabled in Blimp, so this function is a no-op.
-void BlimpMetricsServiceClient::OnRecordingDisabled() {}
-
bool BlimpMetricsServiceClient::IsOffTheRecordSessionActive() {
// Blimp does not have incognito mode.
return false;

Powered by Google App Engine
This is Rietveld 408576698