Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: blimp/engine/app/blimp_metrics_service_client.cc

Issue 2248793002: Remove OnRecordingDisabled() metrics client interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add helper function Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/engine/app/blimp_metrics_service_client.h" 5 #include "blimp/engine/app/blimp_metrics_service_client.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/i18n/rtl.h" 8 #include "base/i18n/rtl.h"
9 #include "base/lazy_instance.h" 9 #include "base/lazy_instance.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 } 83 }
84 84
85 BlimpMetricsServiceClient::~BlimpMetricsServiceClient() {} 85 BlimpMetricsServiceClient::~BlimpMetricsServiceClient() {}
86 86
87 metrics::MetricsService* BlimpMetricsServiceClient::GetMetricsService() { 87 metrics::MetricsService* BlimpMetricsServiceClient::GetMetricsService() {
88 return metrics_service_.get(); 88 return metrics_service_.get();
89 } 89 }
90 90
91 // In Chrome, UMA and Breakpad are enabled/disabled together by the same 91 // In Chrome, UMA and Breakpad are enabled/disabled together by the same
92 // checkbox and they share the same client ID (a.k.a. GUID). 92 // checkbox and they share the same client ID (a.k.a. GUID).
93 // This is not required by Blimp, so these are no-ops. 93 // This is not required by Blimp, so this is a no-op.
94 void BlimpMetricsServiceClient::SetMetricsClientId( 94 void BlimpMetricsServiceClient::SetMetricsClientId(
95 const std::string& client_id) {} 95 const std::string& client_id) {}
96 96
97 // Recording can not be disabled in Blimp, so this function is a no-op.
98 void BlimpMetricsServiceClient::OnRecordingDisabled() {}
99
100 bool BlimpMetricsServiceClient::IsOffTheRecordSessionActive() { 97 bool BlimpMetricsServiceClient::IsOffTheRecordSessionActive() {
101 // Blimp does not have incognito mode. 98 // Blimp does not have incognito mode.
102 return false; 99 return false;
103 } 100 }
104 101
105 int32_t BlimpMetricsServiceClient::GetProduct() { 102 int32_t BlimpMetricsServiceClient::GetProduct() {
106 // Indicates product family (e.g. Chrome v Android Webview), not reported 103 // Indicates product family (e.g. Chrome v Android Webview), not reported
107 // platform (e.g. Chrome_Linux, Chrome_Mac). 104 // platform (e.g. Chrome_Linux, Chrome_Mac).
108 return metrics::ChromeUserMetricsExtension::CHROME; 105 return metrics::ChromeUserMetricsExtension::CHROME;
109 } 106 }
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 BlimpMetricsServiceClient::GetMetricsReportingDefaultState() { 159 BlimpMetricsServiceClient::GetMetricsReportingDefaultState() {
163 return metrics::EnableMetricsDefault::OPT_IN; 160 return metrics::EnableMetricsDefault::OPT_IN;
164 } 161 }
165 162
166 bool BlimpMetricsServiceClient::IsConsentGiven() { 163 bool BlimpMetricsServiceClient::IsConsentGiven() {
167 return true; 164 return true;
168 } 165 }
169 166
170 } // namespace engine 167 } // namespace engine
171 } // namespace blimp 168 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698