android_webview/browser/aw_metrics_service_client.h - Issue 2248793002: Remove OnRecordingDisabled() metrics client interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_metrics_service_client.h

Issue 2248793002: Remove OnRecordingDisabled() metrics client interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add helper function Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/browser/aw_metrics_service_client.h

diff --git a/android_webview/browser/aw_metrics_service_client.h b/android_webview/browser/aw_metrics_service_client.h

index 13f78347d32a61030acc37267d142c5c04dc9980..e16bb8cfc3ca3a1774cad4e614388bce6fcb54c6 100644

--- a/android_webview/browser/aw_metrics_service_client.h

+++ b/android_webview/browser/aw_metrics_service_client.h

@@ -57,7 +57,6 @@ class AwMetricsServiceClient : public metrics::MetricsServiceClient,

// until initialization has asynchronously finished.

metrics::MetricsService* GetMetricsService() override;

void SetMetricsClientId(const std::string& client_id) override;

- void OnRecordingDisabled() override;

bool IsOffTheRecordSessionActive() override;

int32_t GetProduct() override;

std::string GetApplicationLocale() override;

« no previous file with comments | « no previous file | android_webview/browser/aw_metrics_service_client.cc » ('j') | chrome/browser/android/metrics/uma_session_stats.cc » ('J')