Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Unified Diff: android_webview/browser/aw_metrics_service_client.cc

Issue 2248793002: Remove OnRecordingDisabled() metrics client interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add helper function Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_metrics_service_client.cc
diff --git a/android_webview/browser/aw_metrics_service_client.cc b/android_webview/browser/aw_metrics_service_client.cc
index 3129fe9df65064f791f6c049afb13289da49c0c8..7ef4741146ef803f988f6d5148a93982cc89eecf 100644
--- a/android_webview/browser/aw_metrics_service_client.cc
+++ b/android_webview/browser/aw_metrics_service_client.cc
@@ -159,13 +159,11 @@ metrics::MetricsService* AwMetricsServiceClient::GetMetricsService() {
// In Chrome, UMA and Breakpad are enabled/disabled together by the same
// checkbox and they share the same client ID (a.k.a. GUID). SetMetricsClientId
-// and OnRecordingDisabled are intended to provide the ID to Breakpad. In
-// WebView, UMA and Breakpad are independent, so these are no-ops.
+// is intended to provide the ID to Breakpad. In WebView, UMA and Breakpad are
+// independent, so this is a no-op.
void AwMetricsServiceClient::SetMetricsClientId(const std::string& client_id) {}
-void AwMetricsServiceClient::OnRecordingDisabled() {}
-
bool AwMetricsServiceClient::IsOffTheRecordSessionActive() {
// WebView has no incognito mode.
return false;

Powered by Google App Engine
This is Rietveld 408576698