Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: src/interpreter/bytecode-array-writer.cc

Issue 2248673002: Avoid accessing Isolate in source position logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/full-codegen.cc ('k') | src/log.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-array-writer.cc
diff --git a/src/interpreter/bytecode-array-writer.cc b/src/interpreter/bytecode-array-writer.cc
index 4263a623a0585f2e1da5cdd124bebbf04de0b218..ef1c0f53a12f1a5877843d93931293b92c5bd4f3 100644
--- a/src/interpreter/bytecode-array-writer.cc
+++ b/src/interpreter/bytecode-array-writer.cc
@@ -24,7 +24,7 @@ BytecodeArrayWriter::BytecodeArrayWriter(
bytecodes_(zone),
max_register_count_(0),
unbound_jumps_(0),
- source_position_table_builder_(isolate, zone, source_position_mode),
+ source_position_table_builder_(zone, source_position_mode),
constant_array_builder_(constant_array_builder) {}
// override
@@ -49,10 +49,9 @@ Handle<BytecodeArray> BytecodeArrayWriter::ToBytecodeArray(
constant_pool);
bytecode_array->set_handler_table(*handler_table);
Handle<ByteArray> source_position_table =
- source_position_table_builder()->ToSourcePositionTable();
+ source_position_table_builder()->ToSourcePositionTable(
+ isolate(), Handle<AbstractCode>::cast(bytecode_array));
bytecode_array->set_source_position_table(*source_position_table);
- source_position_table_builder()->EndJitLogging(
- AbstractCode::cast(*bytecode_array));
return bytecode_array;
}
« no previous file with comments | « src/full-codegen/full-codegen.cc ('k') | src/log.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698