[interpreter] Add CreateBlockContext bytecode

[interpreter] Add CreateBlockContext bytecode

Allows us to create a corresponding TurboFan node, so TF can
optimize it.

BUG=v8:4280
LOG=n

Committed: https://crrev.com/b07444b16f4c4462fe72abe811ee354ea2dde266
Cr-Commit-Position: refs/heads/master@{#38651}

[klaasb, 2016-08-15 09:27:14]

The CQ bit was checked by klaasb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 09:27:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 09:40:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 09:40:30]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[klaasb, 2016-08-15 14:02:02]

The CQ bit was checked by klaasb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 14:02:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 14:03:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 14:03:22]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/10946)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/6973)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/21792)

[klaasb, 2016-08-15 15:28:52]

The CQ bit was checked by klaasb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 15:28:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[klaasb, 2016-08-15 15:29:28]

Description was changed from

==========
[interpreter] Add CreateBlockContext bytecode

Allows us to create a TurboFan CreateBlockContext node, so TF can
optimize it.

BUG=v8:4280
LOG=n
==========

to

==========
[interpreter] Add CreateBlockContext bytecode

Allows us to create a corresponding TurboFan node, so TF can
optimize it.

BUG=v8:4280
LOG=n
==========

[klaasb, 2016-08-15 15:31:02]

klaasb@google.com changed reviewers:
+ mstarzinger@chromium.org, rmcilroy@chromium.org

[rmcilroy, 2016-08-15 16:01:04]

Couple of nits, but LGTM once they are addressed. Thanks.

https://codereview.chromium.org/2248633002/diff/60001/src/interpreter/bytecod...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/2248633002/diff/60001/src/interpreter/bytecod...
src/interpreter/bytecode-generator.cc:3216: scope->GetScopeInfo(isolate()));
Don't use AllocateConstantPoolEntry() (That's only for when you need to allocate
something which you don't yet have the Handle for and will be filled in later).
Instead just pass the Handle<ScopeInfo> to the bytecode builder and do
GetConstantPoolEntry there (e.g., see LoadLiteral(Handle<Object>)

https://codereview.chromium.org/2248633002/diff/60001/src/interpreter/bytecod...
File src/interpreter/bytecodes.h (right):

https://codereview.chromium.org/2248633002/diff/60001/src/interpreter/bytecod...
src/interpreter/bytecodes.h:233: V(CreateBlockContext,
AccumulatorUse::kReadWrite, OperandType::kIdx)         \
nit - move this under CreateFunctionContext (no need for another comment header,
"/* Context allocation */" subsumes both.

[commit-bot: I haz the power, 2016-08-15 16:02:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 16:02:32]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-08-16 08:23:41]

LGTM from my end as well.

https://codereview.chromium.org/2248633002/diff/60001/src/interpreter/bytecod...
File src/interpreter/bytecodes.h (right):

https://codereview.chromium.org/2248633002/diff/60001/src/interpreter/bytecod...
src/interpreter/bytecodes.h:233: V(CreateBlockContext,
AccumulatorUse::kReadWrite, OperandType::kIdx)         \
On 2016/08/15 16:01:04, rmcilroy wrote:
> nit - move this under CreateFunctionContext (no need for another comment
header,
> "/* Context allocation */" subsumes both.

+1

[klaasb, 2016-08-16 10:40:09]

https://codereview.chromium.org/2248633002/diff/60001/src/interpreter/bytecod...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/2248633002/diff/60001/src/interpreter/bytecod...
src/interpreter/bytecode-generator.cc:3216: scope->GetScopeInfo(isolate()));
On 2016/08/15 16:01:04, rmcilroy wrote:
> Don't use AllocateConstantPoolEntry() (That's only for when you need to
allocate
> something which you don't yet have the Handle for and will be filled in
later).
> Instead just pass the Handle<ScopeInfo> to the bytecode builder and do
> GetConstantPoolEntry there (e.g., see LoadLiteral(Handle<Object>)

Done.

https://codereview.chromium.org/2248633002/diff/60001/src/interpreter/bytecod...
File src/interpreter/bytecodes.h (right):

https://codereview.chromium.org/2248633002/diff/60001/src/interpreter/bytecod...
src/interpreter/bytecodes.h:233: V(CreateBlockContext,
AccumulatorUse::kReadWrite, OperandType::kIdx)         \
On 2016/08/16 08:23:41, Michael Starzinger wrote:
> On 2016/08/15 16:01:04, rmcilroy wrote:
> > nit - move this under CreateFunctionContext (no need for another comment
> header,
> > "/* Context allocation */" subsumes both.
> 
> +1

Done.

[klaasb, 2016-08-16 10:40:21]

The CQ bit was checked by klaasb@google.com

[klaasb, 2016-08-16 10:40:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2248633002/#ps80001
(title: "comments")

[commit-bot: I haz the power, 2016-08-16 10:40:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 11:07:27]

Description was changed from

==========
[interpreter] Add CreateBlockContext bytecode

Allows us to create a corresponding TurboFan node, so TF can
optimize it.

BUG=v8:4280
LOG=n
==========

to

==========
[interpreter] Add CreateBlockContext bytecode

Allows us to create a corresponding TurboFan node, so TF can
optimize it.

BUG=v8:4280
LOG=n
==========

[commit-bot: I haz the power, 2016-08-16 11:07:28]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-16 11:07:49]

Description was changed from

==========
[interpreter] Add CreateBlockContext bytecode

Allows us to create a corresponding TurboFan node, so TF can
optimize it.

BUG=v8:4280
LOG=n
==========

to

==========
[interpreter] Add CreateBlockContext bytecode

Allows us to create a corresponding TurboFan node, so TF can
optimize it.

BUG=v8:4280
LOG=n

Committed: https://crrev.com/b07444b16f4c4462fe72abe811ee354ea2dde266
Cr-Commit-Position: refs/heads/master@{#38651}
==========

[commit-bot: I haz the power, 2016-08-16 11:07:50]

Patchset 5 (id:??) landed as
https://crrev.com/b07444b16f4c4462fe72abe811ee354ea2dde266
Cr-Commit-Position: refs/heads/master@{#38651}