Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2248463002: Get rid of FX_SMALL_RECT. (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@fontclean
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : rebase #

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -89 lines) Patch
M core/fpdfapi/fpdf_font/cpdf_cidfont.h View 1 chunk +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_cidfont.cpp View 1 2 9 chunks +47 lines, -36 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_simplefont.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_simplefont.cpp View 1 2 4 chunks +16 lines, -16 lines 0 comments Download
M core/fpdfapi/fpdf_font/font_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxcrt/include/fx_coordinates.h View 3 chunks +5 lines, -28 lines 0 comments Download

Depends on Patchset:

Issue 2248453002 Patch 40001

Dependent Patchsets:

Issue 2248473002 Patch 20001

Messages

Total messages: 18 (12 generated)
Lei Zhang
Depends on https://codereview.chromium.org/2248453002
4 years, 4 months ago (2016-08-15 05:51:47 UTC) #6
dsinclair
https://codereview.chromium.org/2248463002/diff/1/core/fpdfapi/fpdf_font/cpdf_cidfont.cpp File core/fpdfapi/fpdf_font/cpdf_cidfont.cpp (right): https://codereview.chromium.org/2248463002/diff/1/core/fpdfapi/fpdf_font/cpdf_cidfont.cpp#newcode224 core/fpdfapi/fpdf_font/cpdf_cidfont.cpp:224: return m_pCMap ? m_pCMap->CIDFromCharCode(charcode) : (uint16_t)charcode; static_cast https://codereview.chromium.org/2248463002/diff/1/core/fpdfapi/fpdf_font/cpdf_cidfont.cpp#newcode560 core/fpdfapi/fpdf_font/cpdf_cidfont.cpp:560: ...
4 years, 4 months ago (2016-08-15 12:48:03 UTC) #7
dsinclair
lgtm w/ above nits.
4 years, 4 months ago (2016-08-15 12:54:59 UTC) #8
Lei Zhang
https://codereview.chromium.org/2248463002/diff/1/core/fpdfapi/fpdf_font/cpdf_cidfont.cpp File core/fpdfapi/fpdf_font/cpdf_cidfont.cpp (right): https://codereview.chromium.org/2248463002/diff/1/core/fpdfapi/fpdf_font/cpdf_cidfont.cpp#newcode224 core/fpdfapi/fpdf_font/cpdf_cidfont.cpp:224: return m_pCMap ? m_pCMap->CIDFromCharCode(charcode) : (uint16_t)charcode; On 2016/08/15 12:48:03, ...
4 years, 4 months ago (2016-08-15 17:05:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248463002/40001
4 years, 4 months ago (2016-08-15 17:49:10 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 17:49:28 UTC) #18
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/1679d3ae2e0e64c7aba811476341a153dcef...

Powered by Google App Engine
This is Rietveld 408576698