Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2248453002: Use a std::vector in fpdf_font code. (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -109 lines) Patch
M core/fpdfapi/fpdf_font/cpdf_cidfont.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_font.cpp View 7 chunks +21 lines, -19 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_simplefont.h View 2 chunks +3 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_simplefont.cpp View 2 chunks +15 lines, -17 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_truetypefont.cpp View 1 2 7 chunks +32 lines, -34 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_type1font.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_type3font.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_font/font_int.h View 1 chunk +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font.cpp View 2 chunks +14 lines, -17 lines 0 comments Download
M core/fpdfapi/fpdf_font/include/cpdf_font.h View 2 chunks +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Lei Zhang
4 years, 4 months ago (2016-08-15 05:51:18 UTC) #6
dsinclair
lgtm w/ nit. https://codereview.chromium.org/2248453002/diff/1/core/fpdfapi/fpdf_font/cpdf_truetypefont.cpp File core/fpdfapi/fpdf_font/cpdf_truetypefont.cpp (right): https://codereview.chromium.org/2248453002/diff/1/core/fpdfapi/fpdf_font/cpdf_truetypefont.cpp#newcode199 core/fpdfapi/fpdf_font/cpdf_truetypefont.cpp:199: } nit: no {}'s (and a ...
4 years, 4 months ago (2016-08-15 12:54:40 UTC) #7
Lei Zhang
https://codereview.chromium.org/2248453002/diff/1/core/fpdfapi/fpdf_font/cpdf_truetypefont.cpp File core/fpdfapi/fpdf_font/cpdf_truetypefont.cpp (right): https://codereview.chromium.org/2248453002/diff/1/core/fpdfapi/fpdf_font/cpdf_truetypefont.cpp#newcode199 core/fpdfapi/fpdf_font/cpdf_truetypefont.cpp:199: } On 2016/08/15 12:54:40, dsinclair wrote: > nit: no ...
4 years, 4 months ago (2016-08-15 17:00:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248453002/40001
4 years, 4 months ago (2016-08-15 17:00:55 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 17:21:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/93ee11937bc2351882648f6aa1127883adbf...

Powered by Google App Engine
This is Rietveld 408576698