Viewport resize anchoring should use the current layout viewport.

Viewport resize anchoring should use the current layout viewport.

The current viewport resize anchor assumes the FrameView is always the layout
viewport. This is not true in the setRootScroller experiment where an arbitrary
<div> may become the layout viewport in RootFrameViewport.

I've moved the anchoring logic into RootFrameViewport to keep this information
encapsulated and used the layout viewport as reported by the RootFrameViewport
class

BUG=505516
Committed: https://crrev.com/d17622aad88e3646b8e91d22a8ca46308cc8a0ae
Cr-Commit-Position: refs/heads/master@{#413376}

[bokan, 2016-08-12 23:56:41]

Description was changed from

==========
Viewport resize anchoring should use the current layout viewport.

The current viewport resize anchor assumes the FrameView is always the layout
viewport. This is not true in the setRootScroller experiment where an arbitrary
<div> may become the layout viewport in RootFrameViewport.

I've moved the anchoring logic into RootFrameViewport to keep this information
encapsulated and used the layout viewport as reported by the RootFrameViewport
class

BUG=505516
==========

to

==========
Viewport resize anchoring should use the current layout viewport.

The current viewport resize anchor assumes the FrameView is always the layout
viewport. This is not true in the setRootScroller experiment where an arbitrary
<div> may become the layout viewport in RootFrameViewport.

I've moved the anchoring logic into RootFrameViewport to keep this information
encapsulated and used the layout viewport as reported by the RootFrameViewport
class

BUG=505516
==========

[bokan, 2016-08-12 23:56:41]

bokan@chromium.org changed reviewers:
+ skobes@chromium.org

[bokan, 2016-08-12 23:56:49]

Skobes, ptal.

[skobes, 2016-08-13 00:16:11]

lgtm w/ nit

https://codereview.chromium.org/2248433002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2248433002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameView.cpp:815: ?
static_cast<ScrollableArea*>(m_viewportScrollableArea.get())
Can you avoid the cast with a ScrollableArea* temp var, or by using "if" instead
of "?:" ?

[bokan, 2016-08-13 00:38:22]

https://codereview.chromium.org/2248433002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2248433002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameView.cpp:815: ?
static_cast<ScrollableArea*>(m_viewportScrollableArea.get())
On 2016/08/13 00:16:11, skobes wrote:
> Can you avoid the cast with a ScrollableArea* temp var, or by using "if"
instead
> of "?:" ?

Replaced with a ScrollableArea* temp

[bokan, 2016-08-13 00:39:17]

The CQ bit was checked by bokan@chromium.org

[bokan, 2016-08-13 00:39:18]

The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/2248433002/#ps20001
(title: "Replaced static_cast with temp variable")

[commit-bot: I haz the power, 2016-08-13 00:39:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 01:51:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-13 01:51:40]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bokan, 2016-08-20 22:06:54]

The CQ bit was checked by bokan@chromium.org

[bokan, 2016-08-20 22:06:55]

The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/2248433002/#ps40001
(title: "Rebase + Fixed test")

[commit-bot: I haz the power, 2016-08-20 22:07:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 23:16:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 23:16:57]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bokan, 2016-08-21 17:16:08]

The CQ bit was checked by bokan@chromium.org

[bokan, 2016-08-21 17:16:08]

The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/2248433002/#ps60001
(title: "Forgot to add test file")

[commit-bot: I haz the power, 2016-08-21 17:16:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-21 19:36:57]

Description was changed from

==========
Viewport resize anchoring should use the current layout viewport.

The current viewport resize anchor assumes the FrameView is always the layout
viewport. This is not true in the setRootScroller experiment where an arbitrary
<div> may become the layout viewport in RootFrameViewport.

I've moved the anchoring logic into RootFrameViewport to keep this information
encapsulated and used the layout viewport as reported by the RootFrameViewport
class

BUG=505516
==========

to

==========
Viewport resize anchoring should use the current layout viewport.

The current viewport resize anchor assumes the FrameView is always the layout
viewport. This is not true in the setRootScroller experiment where an arbitrary
<div> may become the layout viewport in RootFrameViewport.

I've moved the anchoring logic into RootFrameViewport to keep this information
encapsulated and used the layout viewport as reported by the RootFrameViewport
class

BUG=505516
==========

[commit-bot: I haz the power, 2016-08-21 19:36:58]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-21 19:38:45]

Description was changed from

==========
Viewport resize anchoring should use the current layout viewport.

The current viewport resize anchor assumes the FrameView is always the layout
viewport. This is not true in the setRootScroller experiment where an arbitrary
<div> may become the layout viewport in RootFrameViewport.

I've moved the anchoring logic into RootFrameViewport to keep this information
encapsulated and used the layout viewport as reported by the RootFrameViewport
class

BUG=505516
==========

to

==========
Viewport resize anchoring should use the current layout viewport.

The current viewport resize anchor assumes the FrameView is always the layout
viewport. This is not true in the setRootScroller experiment where an arbitrary
<div> may become the layout viewport in RootFrameViewport.

I've moved the anchoring logic into RootFrameViewport to keep this information
encapsulated and used the layout viewport as reported by the RootFrameViewport
class

BUG=505516

Committed: https://crrev.com/d17622aad88e3646b8e91d22a8ca46308cc8a0ae
Cr-Commit-Position: refs/heads/master@{#413376}
==========

[commit-bot: I haz the power, 2016-08-21 19:38:46]

Patchset 4 (id:??) landed as
https://crrev.com/d17622aad88e3646b8e91d22a8ca46308cc8a0ae
Cr-Commit-Position: refs/heads/master@{#413376}