Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: third_party/WebKit/Source/core/frame/RootFrameViewport.cpp

Issue 2248433002: Viewport resize anchoring should use the current layout viewport. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rootScrollerCompositorWork
Patch Set: Forgot to add test file Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/RootFrameViewport.cpp
diff --git a/third_party/WebKit/Source/core/frame/RootFrameViewport.cpp b/third_party/WebKit/Source/core/frame/RootFrameViewport.cpp
index 5b1435d3f041072cba94559554389ac5b4998df8..c9aa3a871a5665b18117045581f373f14963bad9 100644
--- a/third_party/WebKit/Source/core/frame/RootFrameViewport.cpp
+++ b/third_party/WebKit/Source/core/frame/RootFrameViewport.cpp
@@ -23,6 +23,39 @@ void RootFrameViewport::setLayoutViewport(ScrollableArea& newLayoutViewport)
m_layoutViewport = &newLayoutViewport;
}
+void RootFrameViewport::restoreToAnchor(const DoublePoint& targetPosition)
+{
+ // Clamp the scroll offset of each viewport now so that we force any invalid
+ // offsets to become valid so we can compute the correct deltas.
+ visualViewport().setScrollPosition(
+ visualViewport().scrollPositionDouble(), ProgrammaticScroll);
+ layoutViewport().setScrollPosition(
+ layoutViewport().scrollPositionDouble(), ProgrammaticScroll);
+
+ DoubleSize delta = targetPosition - scrollPositionDouble();
+
+ visualViewport().setScrollPosition(
+ visualViewport().scrollPositionDouble() + delta, ProgrammaticScroll);
+
+ delta = targetPosition - scrollPositionDouble();
+
+ // Since the main thread FrameView has integer scroll offsets, scroll it to
+ // the next pixel and then we'll scroll the visual viewport again to
+ // compensate for the sub-pixel offset. We need this "overscroll" to ensure
+ // the pixel of which we want to be partially in appears fully inside the
+ // FrameView since the VisualViewport is bounded by the FrameView.
+ IntSize layoutDelta = IntSize(
+ delta.width() < 0 ? floor(delta.width()) : ceil(delta.width()),
+ delta.height() < 0 ? floor(delta.height()) : ceil(delta.height()));
+
+ layoutViewport().setScrollPosition(
+ layoutViewport().scrollPosition() + layoutDelta, ProgrammaticScroll);
+
+ delta = targetPosition - scrollPositionDouble();
+ visualViewport().setScrollPosition(
+ visualViewport().scrollPositionDouble() + delta, ProgrammaticScroll);
+}
+
LayoutBox* RootFrameViewport::layoutBox() const
{
return layoutViewport().layoutBox();
« no previous file with comments | « third_party/WebKit/Source/core/frame/RootFrameViewport.h ('k') | third_party/WebKit/Source/web/ResizeViewportAnchor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698