Stop SpellCheckRequest from checking canCheckAsynchronously()

Stop SpellCheckRequest from checking canCheckAsynchronously()

This patch removes static function canCheckAsynchronously() from
SpellCheckRequester.cpp and stops SpellCheckRequest from calling it.

The removed function is legacy code from the old age before the removal
of synchronous spell checking. In addition, the items checked by this
function do not make much sense now -- either incorrect or redundant.
Hence, the function is removed.

This patch is also a preparation for reducing the use of
TextCheckingParagraph: http://crrev.com/2273453003

BUG=640456
TEST=editing/spelling/paste_into_element_starting_with_invisible.html

Committed: https://crrev.com/7168dd4011adfe053b7a5c0f308fcf7b1495b31b
Cr-Commit-Position: refs/heads/master@{#414049}

[Xiaocheng, 2016-08-18 03:58:24]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 03:58:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 05:14:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 05:14:41]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-08-23 10:25:40]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 10:26:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-23 10:30:11]

Description was changed from

==========
Stop SpellCheckRequest from checking isSpellCheckingEnabledFor()

BUG=
==========

to

==========
Stop SpellCheckRequest from checking canCheckAsynchronously()

This patch removes static function canCheckAsynchronously() from
SpellCheckRequester.cpp and stops SpellCheckRequest from calling it.

The removed function is legacy code from the old age before the removal
of synchronous spell checking. In addition, the items checked by this
function do not make much sense now -- either incorrect or redundant.
Hence, the function is removed.

BUG=n/a
TEST=n/a; no behavior change
==========

[commit-bot: I haz the power, 2016-08-23 11:49:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 11:49:23]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xiaocheng, 2016-08-24 03:15:51]

Description was changed from

==========
Stop SpellCheckRequest from checking canCheckAsynchronously()

This patch removes static function canCheckAsynchronously() from
SpellCheckRequester.cpp and stops SpellCheckRequest from calling it.

The removed function is legacy code from the old age before the removal
of synchronous spell checking. In addition, the items checked by this
function do not make much sense now -- either incorrect or redundant.
Hence, the function is removed.

BUG=n/a
TEST=n/a; no behavior change
==========

to

==========
Stop SpellCheckRequest from checking canCheckAsynchronously()

This patch removes static function canCheckAsynchronously() from
SpellCheckRequester.cpp and stops SpellCheckRequest from calling it.

The removed function is legacy code from the old age before the removal
of synchronous spell checking. In addition, the items checked by this
function do not make much sense now -- either incorrect or redundant.
Hence, the function is removed.

BUG=640456
TEST=n/a; no behavior change
==========

[Xiaocheng, 2016-08-24 03:40:28]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 03:40:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-24 03:41:39]

Description was changed from

==========
Stop SpellCheckRequest from checking canCheckAsynchronously()

This patch removes static function canCheckAsynchronously() from
SpellCheckRequester.cpp and stops SpellCheckRequest from calling it.

The removed function is legacy code from the old age before the removal
of synchronous spell checking. In addition, the items checked by this
function do not make much sense now -- either incorrect or redundant.
Hence, the function is removed.

BUG=640456
TEST=n/a; no behavior change
==========

to

==========
Stop SpellCheckRequest from checking canCheckAsynchronously()

This patch removes static function canCheckAsynchronously() from
SpellCheckRequester.cpp and stops SpellCheckRequest from calling it.

The removed function is legacy code from the old age before the removal
of synchronous spell checking. In addition, the items checked by this
function do not make much sense now -- either incorrect or redundant.
Hence, the function is removed.

editing/style/table-selection.html is rebaselined due to the appearance
of spelling markers in its pixel results.

BUG=640456
TEST=editing/spelling/paste_into_element_starting_with_invisible.html
==========

[Xiaocheng, 2016-08-24 04:21:25]

Description was changed from

==========
Stop SpellCheckRequest from checking canCheckAsynchronously()

This patch removes static function canCheckAsynchronously() from
SpellCheckRequester.cpp and stops SpellCheckRequest from calling it.

The removed function is legacy code from the old age before the removal
of synchronous spell checking. In addition, the items checked by this
function do not make much sense now -- either incorrect or redundant.
Hence, the function is removed.

editing/style/table-selection.html is rebaselined due to the appearance
of spelling markers in its pixel results.

BUG=640456
TEST=editing/spelling/paste_into_element_starting_with_invisible.html
==========

to

==========
Stop SpellCheckRequest from checking canCheckAsynchronously()

This patch removes static function canCheckAsynchronously() from
SpellCheckRequester.cpp and stops SpellCheckRequest from calling it.

The removed function is legacy code from the old age before the removal
of synchronous spell checking. In addition, the items checked by this
function do not make much sense now -- either incorrect or redundant.
Hence, the function is removed.

editing/style/table-selection.html is rebaselined due to the appearance
of spelling markers in its pixel results.

This patch is also a preparation for reducing the use of
TextCheckingParagraph: http://crrev.com/2273453003

BUG=640456
TEST=editing/spelling/paste_into_element_starting_with_invisible.html
==========

[Xiaocheng, 2016-08-24 04:38:08]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-08-24 04:38:09]

PTAL.

[commit-bot: I haz the power, 2016-08-24 05:26:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 05:26:23]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yosin_UTC9, 2016-08-24 06:00:51]

lgtm

Could you convert "table-selection.html" to use w3c test harness rather than
rebaseing it?
Since it doesn't need to check pixels.

[Xiaocheng, 2016-08-24 06:03:33]

On 2016/08/24 at 06:00:51, yosin wrote:
> lgtm
> 
> Could you convert "table-selection.html" to use w3c test harness rather than
rebaseing it?
> Since it doesn't need to check pixels.

It sounds like you job :)

Or let's wait until we have disabled mock spell checker in all unrelated
tests...

[Xiaocheng, 2016-08-24 09:21:45]

Description was changed from

==========
Stop SpellCheckRequest from checking canCheckAsynchronously()

This patch removes static function canCheckAsynchronously() from
SpellCheckRequester.cpp and stops SpellCheckRequest from calling it.

The removed function is legacy code from the old age before the removal
of synchronous spell checking. In addition, the items checked by this
function do not make much sense now -- either incorrect or redundant.
Hence, the function is removed.

editing/style/table-selection.html is rebaselined due to the appearance
of spelling markers in its pixel results.

This patch is also a preparation for reducing the use of
TextCheckingParagraph: http://crrev.com/2273453003

BUG=640456
TEST=editing/spelling/paste_into_element_starting_with_invisible.html
==========

to

==========
Stop SpellCheckRequest from checking canCheckAsynchronously()

This patch removes static function canCheckAsynchronously() from
SpellCheckRequester.cpp and stops SpellCheckRequest from calling it.

The removed function is legacy code from the old age before the removal
of synchronous spell checking. In addition, the items checked by this
function do not make much sense now -- either incorrect or redundant.
Hence, the function is removed.

This patch is also a preparation for reducing the use of
TextCheckingParagraph: http://crrev.com/2273453003

BUG=640456
TEST=editing/spelling/paste_into_element_starting_with_invisible.html
==========

[Xiaocheng, 2016-08-24 09:21:54]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 09:22:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-24 09:34:44]

Rebased the patch on https://codereview.chromium.org/2270293003. Now it doesn't
rebaseline any unrelated test.

[commit-bot: I haz the power, 2016-08-24 11:18:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 11:18:18]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-08-24 11:48:44]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-08-24 11:48:45]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2248413003/#ps60001
(title: "Removed rebaselining of the unrelated test")

[commit-bot: I haz the power, 2016-08-24 11:49:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 11:53:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-24 11:57:01]

Description was changed from

==========
Stop SpellCheckRequest from checking canCheckAsynchronously()

This patch removes static function canCheckAsynchronously() from
SpellCheckRequester.cpp and stops SpellCheckRequest from calling it.

The removed function is legacy code from the old age before the removal
of synchronous spell checking. In addition, the items checked by this
function do not make much sense now -- either incorrect or redundant.
Hence, the function is removed.

This patch is also a preparation for reducing the use of
TextCheckingParagraph: http://crrev.com/2273453003

BUG=640456
TEST=editing/spelling/paste_into_element_starting_with_invisible.html
==========

to

==========
Stop SpellCheckRequest from checking canCheckAsynchronously()

This patch removes static function canCheckAsynchronously() from
SpellCheckRequester.cpp and stops SpellCheckRequest from calling it.

The removed function is legacy code from the old age before the removal
of synchronous spell checking. In addition, the items checked by this
function do not make much sense now -- either incorrect or redundant.
Hence, the function is removed.

This patch is also a preparation for reducing the use of
TextCheckingParagraph: http://crrev.com/2273453003

BUG=640456
TEST=editing/spelling/paste_into_element_starting_with_invisible.html

Committed: https://crrev.com/7168dd4011adfe053b7a5c0f308fcf7b1495b31b
Cr-Commit-Position: refs/heads/master@{#414049}
==========

[commit-bot: I haz the power, 2016-08-24 11:57:02]

Patchset 4 (id:??) landed as
https://crrev.com/7168dd4011adfe053b7a5c0f308fcf7b1495b31b
Cr-Commit-Position: refs/heads/master@{#414049}