third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp - Issue 2248413003: Stop SpellCheckRequest from checking canCheckAsynchronously()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

Issue 2248413003: Stop SpellCheckRequest from checking canCheckAsynchronously() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SpellCheckerDebugInfo

Patch Set: Removed rebaselining of the unrelated test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/spelling/paste_into_element_starting_with_invisible.html ('k') | third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

index b37a5d86c095894551447c485c8b0674d710e165..fb94c33e49e37548572f17ab30c57c0558c2c914 100644

--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

@@ -159,19 +159,9 @@ void SpellCheckRequester::timerFiredToProcessQueuedRequest(TimerBase*)

invokeRequest(m_requestQueue.takeFirst());

}

-static bool canCheckAsynchronously(const Range* range)

- if (!range || !range->firstNode() || !range->firstNode()->layoutObject())

- return false;

- const Node* node = range->startContainer();

- if (node && node->isElementNode() && !toElement(node)->isSpellCheckingEnabled())

- return false;

- return true;

void SpellCheckRequester::requestCheckingFor(SpellCheckRequest* request)

{

- if (!request || !canCheckAsynchronously(request->checkingRange()))

+ if (!request)

return;

DCHECK_EQ(request->data().sequence(), unrequestedTextCheckingSequence);