Implement origin-based deletion of plugin data

chrome/browser/browsing_data/origin_filter_builder.cc

Index: chrome/browser/browsing_data/origin_filter_builder.cc
diff --git a/chrome/browser/browsing_data/origin_filter_builder.cc b/chrome/browser/browsing_data/origin_filter_builder.cc
index 4d13835cf4a539ccb033eeec428154bc37f185f6..34586280a96b8ee97d2cec704358dbe77e711465 100644
--- a/chrome/browser/browsing_data/origin_filter_builder.cc
+++ b/chrome/browser/browsing_data/origin_filter_builder.cc
@@ -84,6 +84,14 @@ OriginFilterBuilder::BuildChannelIDFilter() const {
   return base::Bind(DontDeleteAnythingFilter<std::string>);
 }
 
+base::Callback<bool(const std::string& site)>
+OriginFilterBuilder::BuildPluginFilter() const {
+  NOTREACHED() <<
+      "Origin-based deletion is not suitable for plugins. Please use "
+      "different scoping, such as RegistrableDomainFilterBuilder.";
+  return base::Bind(DontDeleteAnythingFilter<std::string>);

[Bernhard Bauer, 2016/08/18 18:35:59]

If you are stating that this code should never be reached, you don't need to put
in an explicit no-op method here (because that would be handling the failure).
You could just return an empty base::Callback.

[msramek, 2016/08/19 11:16:46]

Done. You're right, this is even against the style guide. Fixed here and above.

+}
+
 bool OriginFilterBuilder::operator==(const OriginFilterBuilder& other) const {
   return origin_list_ == other.origin_list_ && mode() == other.mode();
 }