Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 2248403002: Implement origin-based deletion of plugin data (Closed)

Created:
4 years, 4 months ago by msramek
Modified:
4 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement origin-based deletion of plugin data 1. Plugin data are keyed by domain (e.g. "www.google.com"). Implement a filter matching domains. See all *filter_builder* files. 2. Use BrowsingDataFlashLSOHelper to enumerate sites with plugin data and delete the corresponding LSO cookies. 3. Use MockBrowsingDataFlashLSOHelper to test the functionality. BUG=589586 Committed: https://crrev.com/dd293969ef9cfa5e27dd1f35b5ae549c3e9d1cda Cr-Commit-Position: refs/heads/master@{#413170}

Patch Set 1 : Plugins done. #

Total comments: 18

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+354 lines, -60 lines) Patch
M chrome/browser/browsing_data/browsing_data_filter_builder.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_flash_lso_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_flash_lso_helper.cc View 5 chunks +20 lines, -7 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.h View 1 9 chunks +28 lines, -12 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 1 6 chunks +77 lines, -21 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 3 chunks +86 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/mock_browsing_data_flash_lso_helper.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/mock_browsing_data_flash_lso_helper.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/origin_filter_builder.h View 2 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/browsing_data/origin_filter_builder.cc View 1 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/browsing_data/registrable_domain_filter_builder.h View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/registrable_domain_filter_builder.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/registrable_domain_filter_builder_unittest.cc View 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
msramek
Hi Bernhard, Please have a look! I hope that as a co-author of both NPAPI:ClearSiteData ...
4 years, 4 months ago (2016-08-17 14:50:23 UTC) #3
msramek
On 2016/08/17 14:50:23, msramek wrote: > Hi Bernhard, > > Please have a look! I ...
4 years, 4 months ago (2016-08-18 18:18:06 UTC) #8
Bernhard Bauer
On 2016/08/17 14:50:23, msramek wrote: > Hi Bernhard, > > Please have a look! I ...
4 years, 4 months ago (2016-08-18 18:36:00 UTC) #9
msramek
Thanks Bernhard! I really appreciate your answers as well as quick response (I expected that ...
4 years, 4 months ago (2016-08-19 11:16:47 UTC) #12
Bernhard Bauer
LGTM! https://codereview.chromium.org/2248403002/diff/20001/chrome/browser/browsing_data/browsing_data_remover.cc File chrome/browser/browsing_data/browsing_data_remover.cc (right): https://codereview.chromium.org/2248403002/diff/20001/chrome/browser/browsing_data/browsing_data_remover.cc#newcode1326 chrome/browser/browsing_data/browsing_data_remover.cc:1326: --waiting_for_clear_plugin_data_count_; On 2016/08/19 11:16:46, msramek wrote: > On ...
4 years, 4 months ago (2016-08-19 16:29:39 UTC) #15
msramek
Thanks!
4 years, 4 months ago (2016-08-19 16:57:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248403002/40001
4 years, 4 months ago (2016-08-19 16:58:20 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-19 17:03:01 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 17:16:15 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dd293969ef9cfa5e27dd1f35b5ae549c3e9d1cda
Cr-Commit-Position: refs/heads/master@{#413170}

Powered by Google App Engine
This is Rietveld 408576698