Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2248363003: V8: increase number of shards for arm64 gc stress. (Closed)

Created:
4 years, 4 months ago by tandrii(chromium)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, Michael Achenbach, Benedikt Meurer
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

V8: increase number of shards for arm64 gc stress. Reason: shard#0 is timing out on swarming. Expected follow up: if this helps, shard in other builders as well. R=hablich@chromium.org CC=machenbach@chromium.org BUG=638295 Committed: https://chromium.googlesource.com/chromium/tools/build/+/a415f195afcd9db6c89a5da50df939e76d69b849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M scripts/slave/recipe_modules/v8/builders.py View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___gc_stress.json View 3 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
tandrii(chromium)
4 years, 4 months ago (2016-08-17 10:51:01 UTC) #1
Michael Hablich
On 2016/08/17 10:51:01, tandrii(chromium) wrote: lgtm
4 years, 4 months ago (2016-08-17 10:53:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248363003/1
4 years, 4 months ago (2016-08-17 10:53:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/a415f195afcd9db6c89a5da50df939e76d69b849
4 years, 4 months ago (2016-08-17 10:58:05 UTC) #10
Michael Achenbach
Not sure if more shards are desirable here. The problem at hand is very few, ...
4 years, 3 months ago (2016-08-29 18:30:05 UTC) #12
Michael Achenbach
4 years, 3 months ago (2016-08-30 06:57:26 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2291703003/ by machenbach@chromium.org.

The reason for reverting is: The root cause of the slow tests has been fixed. A
shard increase is not needed..

Powered by Google App Engine
This is Rietveld 408576698