Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2224253003: [runtime] %GrowArrayElements doesn't have a native context in TurboFan. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich, vogelheim
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] %GrowArrayElements doesn't have a native context in TurboFan. When we compile a growing store in TurboFan, we don't pass a (native) context to the %GrowArrayElements fallback function, as the whole logic is actually context independent. However, that means that we need to bailout early in case the object is a prototype, which requires context dependent checks in the array protector code. R=cbruni@chromium.org BUG=chromium:635798 Committed: https://crrev.com/78727d4362f76cad0e384bdf809d59fba4895195 Cr-Commit-Position: refs/heads/master@{#38491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/runtime/runtime-array.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-635798.js View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-09 11:53:12 UTC) #1
Camillo Bruni
lgtm
4 years, 4 months ago (2016-08-09 11:53:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224253003/1
4 years, 4 months ago (2016-08-09 11:54:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 13:02:58 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/78727d4362f76cad0e384bdf809d59fba4895195 Cr-Commit-Position: refs/heads/master@{#38491}
4 years, 4 months ago (2016-08-09 13:03:20 UTC) #10
Michael Achenbach
The test kills arm64 gc stress: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/builds/1969 The test takes too long and lets the ...
4 years, 4 months ago (2016-08-11 10:04:32 UTC) #12
Michael Achenbach
4 years, 3 months ago (2016-08-29 06:26:44 UTC) #13
Message was sent while issue was closed.
Btw: This is also the reason why our arm64 sim debug is purple most of the time.
Test times:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...

This is way too slow. If the test can't be sped up, I'm going to skip it.

Powered by Google App Engine
This is Rietveld 408576698