Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: tests/PrimitiveProcessorTest.cpp

Issue 2248323003: Simplify adding attributes to GrGeometryProcessor (Closed) Base URL: https://chromium.googlesource.com/skia.git@xformhelper
Patch Set: Revert removal of fAttribNames Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/instanced/InstanceProcessor.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/PrimitiveProcessorTest.cpp
diff --git a/tests/PrimitiveProcessorTest.cpp b/tests/PrimitiveProcessorTest.cpp
index 7a080c57aca66349bce6e8dda10c4fea6478fb81..55049ea098b7500781a072b7e842f2f7f1ed5f3a 100644
--- a/tests/PrimitiveProcessorTest.cpp
+++ b/tests/PrimitiveProcessorTest.cpp
@@ -56,12 +56,7 @@ private:
fAttribNames.push_back().printf("attr%d", i);
}
for (auto i = 0; i < numAttribs; ++i) {
- Attribute attribute;
- attribute.fType = kVec2f_GrVertexAttribType;
- attribute.fName = fAttribNames[i].c_str();
- attribute.fOffset = 2 * sizeof(float) * i;
- attribute.fPrecision = kDefault_GrSLPrecision;
- this->addVertexAttrib(attribute);
+ this->addVertexAttrib(fAttribNames[i].c_str(), kVec2f_GrVertexAttribType);
}
};
const char* name() const override { return "Dummy GP"; }
« no previous file with comments | « src/gpu/instanced/InstanceProcessor.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698