tests/PrimitiveProcessorTest.cpp - Issue 2248323003: Simplify adding attributes to GrGeometryProcessor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PrimitiveProcessorTest.cpp

Issue 2248323003: Simplify adding attributes to GrGeometryProcessor (Closed) Base URL: https://chromium.googlesource.com/skia.git@xformhelper

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PrimitiveProcessorTest.cpp

diff --git a/tests/PrimitiveProcessorTest.cpp b/tests/PrimitiveProcessorTest.cpp

index 7a080c57aca66349bce6e8dda10c4fea6478fb81..0ebeba9699f0332804e3f365a97a40c193f415d0 100644

--- a/tests/PrimitiveProcessorTest.cpp

+++ b/tests/PrimitiveProcessorTest.cpp

@@ -57,11 +57,7 @@ private:

}

for (auto i = 0; i < numAttribs; ++i) {

robertphillips 2016/08/17 16:11:32 rm attribute ?

bsalomon 2016/08/17 16:17:44 Done.

Attribute attribute;

- attribute.fType = kVec2f_GrVertexAttribType;

- attribute.fName = fAttribNames[i].c_str();

- attribute.fOffset = 2 * sizeof(float) * i;

- attribute.fPrecision = kDefault_GrSLPrecision;

- this->addVertexAttrib(attribute);

+ this->addVertexAttrib(fAttribNames[i].c_str(), kVec2f_GrVertexAttribType);

}

};

const char* name() const override { return "Dummy GP"; }