Simplify adding attributes to GrGeometryProcessor

tests/PrimitiveProcessorTest.cpp

 /*
  * Copyright 2016 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 // This is a GPU-backend specific test. It relies on static intializers to work
 
 #include "SkTypes.h"
@@ skipping 33 matching lines @@
         this->setBounds(SkRect::MakeWH(1.f, 1.f), HasAABloat::kNo, IsZeroArea::kNo);
     }
 
 private:
     bool onCombineIfPossible(GrBatch*, const GrCaps&) override { return false; }
     void onPrepareDraws(Target* target) const override {
         class GP : public GrGeometryProcessor {
         public:
             GP(int numAttribs) {
                 this->initClassID<GP>();
                 SkASSERT(numAttribs > 1);

[robertphillips, 2016/08/17 16:11:32]

fAttribNames doesn't seem particularly useful.

[bsalomon, 2016/08/17 16:17:44]

Done.

[bsalomon, 2016/08/17 16:19:27]

Actually, it sadly is useful. The Attribute struct just stores a const char* and
so fAttribNames keeps the pointers valid.

                 for (auto i = 0; i < numAttribs; ++i) {
                     fAttribNames.push_back().printf("attr%d", i);
                 }
                 for (auto i = 0; i < numAttribs; ++i) {

[robertphillips, 2016/08/17 16:11:32]

rm attribute ?

[bsalomon, 2016/08/17 16:17:44]

Done.

                     Attribute attribute;
-                    attribute.fType = kVec2f_GrVertexAttribType;
-                    attribute.fName = fAttribNames[i].c_str();
-                    attribute.fOffset = 2 * sizeof(float) * i;
-                    attribute.fPrecision = kDefault_GrSLPrecision;
-                    this->addVertexAttrib(attribute);
+                    this->addVertexAttrib(fAttribNames[i].c_str(), kVec2f_GrVertexAttribType);
                 }
             };
             const char* name() const override { return "Dummy GP"; }
 
             GrGLSLPrimitiveProcessor* createGLSLInstance(const GrGLSLCaps&) const override {
                 class GLSLGP : public GrGLSLGeometryProcessor {
                 public:
                     void onEmitCode(EmitArgs& args, GrGPArgs* gpArgs) override {
                         const GP& gp = args.fGP.cast<GP>();
                         args.fVaryingHandler->emitAttributes(gp);
@@ skipping 61 matching lines @@
     // This one should fail.
     batch.reset(new Batch(attribCnt+1));
     drawContext->drawContextPriv().testingOnly_drawBatch(grPaint, batch);
     context->flush();
 #if GR_GPU_STATS
     REPORTER_ASSERT(reporter, context->getGpu()->stats()->numDraws() == 0);
     REPORTER_ASSERT(reporter, context->getGpu()->stats()->numFailedDraws() == 1);
 #endif
 }
 #endif