chrome/browser/installable/installable_logging.h - Issue 2248293002: Do not install WebAPKs with web manifests with invalid URL components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/installable/installable_logging.h

Issue 2248293002: Do not install WebAPKs with web manifests with invalid URL components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'webapk_updater_non_installable' into webapk_installable_checker Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/webapk/webapk_web_manifest_checker.h ('K') | « chrome/browser/android/webapk/webapk_web_manifest_checker.cc ('k') | chrome/browser/installable/installable_logging.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/installable/installable_logging.h

diff --git a/chrome/browser/installable/installable_logging.h b/chrome/browser/installable/installable_logging.h

index 4ddcd94ee7753e56df945da5f2da29e681d55f58..9c3bd131eec161be34e3c7371b6c67e9eed94510 100644

--- a/chrome/browser/installable/installable_logging.h

+++ b/chrome/browser/installable/installable_logging.h

@@ -44,6 +44,8 @@ enum InstallableStatusCode {

SHOWING_NATIVE_APP_BANNER,

SHOWING_WEB_APP_BANNER,

FAILED_TO_CREATE_BANNER,

+ URL_USERNAME_AND_PASSWORD_NOT_SUPPORTED_FOR_WEBAPK,

dominickn 2016/08/24 03:27:11 I think you can just have one error here - URL_NOT

pkotwicz 2016/08/24 15:04:56 I now use just one error code. You are right that

+ URL_PORT_NOT_SUPPORTED_FOR_WEBAPK,

MAX_ERROR_CODE,

};