Do not install WebAPKs with web manifests with invalid URL components

chrome/browser/installable/installable_logging.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_INSTALLABLE_INSTALLABLE_LOGGING_H_
 #define CHROME_BROWSER_INSTALLABLE_INSTALLABLE_LOGGING_H_
 
 #include <string>
 
 namespace content {
@@ skipping 26 matching lines @@
   NO_ID_SPECIFIED,
   IDS_DO_NOT_MATCH,
   ALREADY_INSTALLED,
   INSUFFICIENT_ENGAGEMENT,
   PACKAGE_NAME_OR_START_URL_EMPTY,
   PREVIOUSLY_BLOCKED,
   PREVIOUSLY_IGNORED,
   SHOWING_NATIVE_APP_BANNER,
   SHOWING_WEB_APP_BANNER,
   FAILED_TO_CREATE_BANNER,
+  URL_USERNAME_AND_PASSWORD_NOT_SUPPORTED_FOR_WEBAPK,

[dominickn, 2016/08/24 03:27:11]

I think you can just have one error here - URL_NOT_SUPPORTED_FOR_WEBAPK. In the
reason string, you can then have "A URL in the manifest contains a username,
password, or port". That makes the checking method simpler because it can return
a boolean rather than an error code. Having just one error code related to
WebAPK URL satisfaction makes sense to me because it's super obvious to the
developer what's gone wrong - they don't need a separate error for the port.

[pkotwicz, 2016/08/24 15:04:56]

I now use just one error code. You are right that it simplifies things a lot.

+  URL_PORT_NOT_SUPPORTED_FOR_WEBAPK,
   MAX_ERROR_CODE,
 };
 
 // Logs a message associated with |code| with a parameter |param| to the
 // devtools console attached to |web_contents|. Does nothing if |web_contents|
 // is nullptr.
 void LogErrorToConsole(content::WebContents* web_contents,
                        InstallableStatusCode code,
                        const std::string& param);
 
 #endif  // CHROME_BROWSER_INSTALLABLE_INSTALLABLE_LOGGING_H_