Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1928)

Unified Diff: chrome/browser/installable/installable_logging.cc

Issue 2248293002: Do not install WebAPKs with web manifests with invalid URL components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_installable_checker Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/installable/installable_logging.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/installable/installable_logging.cc
diff --git a/chrome/browser/installable/installable_logging.cc b/chrome/browser/installable/installable_logging.cc
index 8e54ce0a5918f67360e23ad28c38576f9114f828..9fd06cf0678447f2fd9fe581c428e70e4565e6fb 100644
--- a/chrome/browser/installable/installable_logging.cc
+++ b/chrome/browser/installable/installable_logging.cc
@@ -59,6 +59,8 @@ static const char kNoIdSpecifiedMessage[] =
static const char kIdsDoNotMatchMessage[] =
"a Play Store app URL and Play Store ID were specified in the manifest, "
"but they do not match";
+static const char kUrlNotSupportedForWebApkMessage[] =
dominickn 2016/08/29 00:15:41 Nit: you removed checking the username for a port,
+ "a URL in the web manifest contains a username, password, or port";
} // namespace
@@ -140,6 +142,9 @@ void LogErrorToConsole(content::WebContents* web_contents,
case IDS_DO_NOT_MATCH:
pattern = kIdsDoNotMatchMessage;
break;
+ case URL_NOT_SUPPORTED_FOR_WEBAPK:
+ pattern = kUrlNotSupportedForWebApkMessage;
+ break;
}
if (!pattern)
« no previous file with comments | « chrome/browser/installable/installable_logging.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698